<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Just land it.</p>
<p>Philip<br>
</p>
<div class="moz-cite-prefix">On 12/11/19 1:07 PM, Kit Barton wrote:<br>
</div>
<blockquote type="cite"
cite="mid:OF98FB3EBE.8F40CF74-ON002584CD.0073C00B-002584CD.007412AE@notes.na.collabserv.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial, Helvetica, sans-serif;font-size:9pt">
<div dir="ltr">Thanks Michael and Philip for the clarification.
I was going to ask the same question.</div>
<div dir="ltr"><br>
Do either of you object if I commit a fix to change the name,
with an appropriate comment block? Or would you prefer I post
something on Phabricator for review?</div>
<div dir="ltr"> </div>
<div dir="ltr">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial, Helvetica,
sans-serif;font-size:10.5pt">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial, Helvetica,
sans-serif;font-size:10.5pt">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial, Helvetica,
sans-serif;font-size:10.5pt">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial, Helvetica,
sans-serif;font-size:10.5pt">
<div dir="ltr"><font size="2"
face="Verdana,Arial,Helvetica,sans-serif"><font
size="2"
face="Verdana,Arial,Helvetica,sans-serif"><span
style="font-family:Arial,Helvetica,sans-serif;"><font size="2"><span
style="font-size:0.857em;">Kit Barton,
Ph.D.<br>
STSM, Technical lead for LLVM on Power and
XL Compilers<br>
IBM Toronto Lab, C2/705/8200/MKM<br>
8200 Warden Ave, Markham, L6G 1C7<br>
(905) 413-3452<br>
<a class="moz-txt-link-abbreviated" href="mailto:kbarton@ca.ibm.com">kbarton@ca.ibm.com</a></span></font></span></font></font></div>
</div>
</div>
</div>
</div>
</div>
<div dir="ltr"> </div>
<div dir="ltr"> </div>
<blockquote data-history-content-modified="1" dir="ltr"
style="border-left:solid #aaaaaa 2px; margin-left:5px;
padding-left:5px; direction:ltr; margin-right:0px">-----
Original message -----<br>
From: Philip Reames <a class="moz-txt-link-rfc2396E" href="mailto:listmail@philipreames.com"><listmail@philipreames.com></a><br>
To: Michael Kruse <a class="moz-txt-link-rfc2396E" href="mailto:llvm-commits@meinersbur.de"><llvm-commits@meinersbur.de></a><br>
Cc: Kit Barton <a class="moz-txt-link-rfc2396E" href="mailto:kbarton@ca.ibm.com"><kbarton@ca.ibm.com></a>, Kit Barton
<a class="moz-txt-link-rfc2396E" href="mailto:llvmlistbot@llvm.org"><llvmlistbot@llvm.org></a>, llvm-commits
<a class="moz-txt-link-rfc2396E" href="mailto:llvm-commits@lists.llvm.org"><llvm-commits@lists.llvm.org></a><br>
Subject: [EXTERNAL] Re: [llvm] 942c994 - [Loop] Add isRotated
method to Loop class.<br>
Date: Wed, Dec 11, 2019 3:53 PM<br>
<div><font size="2" face="Default Monospace,Courier
New,Courier,monospace">On 12/11/19 12:45 PM, Michael Kruse
wrote:<br>
> Am Mi., 11. Dez. 2019 um 11:11 Uhr schrieb Philip
Reames via<br>
> llvm-commits <a class="moz-txt-link-rfc2396E" href="mailto:llvm-commits@lists.llvm.org"><llvm-commits@lists.llvm.org></a>:<br>
>> Can you add a more detailed method comment as to
what rotated means in<br>
>> this context? In particular, it doesn't imply
the loop has been<br>
>> rotated, it checks the form of the loop
structure.<br>
> By "has been rotated", do you mean that LoopRotate
transformed the<br>
> loop, excluding that cases where LoopRotate did not
do anything or did<br>
> not run?<br>
> Would calling the method "isRotatedForm()"
disambiguate this?<br>
Yes, and yes.<br>
><br>
> Michael</font><br>
</div>
</blockquote>
<div dir="ltr"> </div>
</div>
<br>
</blockquote>
</body>
</html>