[PATCH] D70767: [Attributor] Add an Attributor CG-SCC pass

Wed Dec 11 11:59:18 PST 2019

jdoerfert marked an inline comment as done.
jdoerfert added a comment.

In D70767#1774799 <https://reviews.llvm.org/D70767#1774799>, @xbolva00 wrote:

> Can you add a testcase from https://reviews.llvm.org/D70737, please?

Will do.

In D70767#1779651 <https://reviews.llvm.org/D70767#1779651>, @uenoku wrote:

> I think changes for `replaceAllUsesWith` are not related to CG-SCC pass. For that part, LGTM. Could you split the patch?

Will do.

================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:525

+  // Infer attributes on declarations, call sites, arguments, etc.
+  MPM.add(createAttributorLegacyPass());
----------------
uenoku wrote:
> Do you have any reason why you move Attributor here?
The module pass should run early to improve the passes before the inliner loop, e.g., createCalledValuePropagationPass below.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70767/new/

https://reviews.llvm.org/D70767