[PATCH] D70767: [Attributor] Add an Attributor CG-SCC pass

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 06:27:05 PST 2019


uenoku added a comment.

I think changes for `replaceAllUsesWith` are not related to CG-SCC pass. For that part, LGTM. Could you split the patch?



================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:525
 
+  // Infer attributes on declarations, call sites, arguments, etc.
+  MPM.add(createAttributorLegacyPass());
----------------
Do you have any reason why you move Attributor here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70767/new/

https://reviews.llvm.org/D70767





More information about the llvm-commits mailing list