[llvm] db76588 - [StringRef] Test all default characters in unit test

[Jonas Devlieghere via llvm-commits]

Author: Jonas Devlieghere
Date: 2019-12-11T10:46:07-08:00
New Revision: db76588964ee255da1f32b06565a2cd899a82947

URL: https://github.com/llvm/llvm-project/commit/db76588964ee255da1f32b06565a2cd899a82947
DIFF: https://github.com/llvm/llvm-project/commit/db76588964ee255da1f32b06565a2cd899a82947.diff

LOG: [StringRef] Test all default characters in unit test

The default characters for trim, ltrim and rtrim are " \t\n\v\f\r" but
only spaces were tested. Test that the others are trimmed as well.

Added: 
    

Modified: 
    llvm/unittests/ADT/StringRefTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ADT/StringRefTest.cpp b/llvm/unittests/ADT/StringRefTest.cpp
index c37ecf36b63a..2e5159dde1ce 100644
--- a/llvm/unittests/ADT/StringRefTest.cpp
+++ b/llvm/unittests/ADT/StringRefTest.cpp
@@ -324,16 +324,20 @@ TEST(StringRefTest, Trim) {
   StringRef Str0("hello");
   StringRef Str1(" hello ");
   StringRef Str2("  hello  ");
+  StringRef Str3("\t\n\v\f\r  hello  \t\n\v\f\r");
 
   EXPECT_EQ(StringRef("hello"), Str0.rtrim());
   EXPECT_EQ(StringRef(" hello"), Str1.rtrim());
   EXPECT_EQ(StringRef("  hello"), Str2.rtrim());
+  EXPECT_EQ(StringRef("\t\n\v\f\r  hello"), Str3.rtrim());
   EXPECT_EQ(StringRef("hello"), Str0.ltrim());
   EXPECT_EQ(StringRef("hello "), Str1.ltrim());
   EXPECT_EQ(StringRef("hello  "), Str2.ltrim());
+  EXPECT_EQ(StringRef("hello  \t\n\v\f\r"), Str3.ltrim());
   EXPECT_EQ(StringRef("hello"), Str0.trim());
   EXPECT_EQ(StringRef("hello"), Str1.trim());
   EXPECT_EQ(StringRef("hello"), Str2.trim());
+  EXPECT_EQ(StringRef("hello"), Str3.trim());
 
   EXPECT_EQ(StringRef("ello"), Str0.trim("hhhhhhhhhhh"));