[PATCH] D71176: [GlobalISel] Delete unused TargetPassConfig::addPreRegBankSelect

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added a reviewer: qcolombet.
Herald added subscribers: llvm-commits, Petar.Avramovic, hiraditya, rovka.
Herald added a project: LLVM.

If there is a need in the future, addRegBankSelect() can be used instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71176

Files:
  llvm/include/llvm/CodeGen/TargetPassConfig.h
  llvm/lib/CodeGen/TargetPassConfig.cpp


Index: llvm/lib/CodeGen/TargetPassConfig.cpp
===================================================================
--- llvm/lib/CodeGen/TargetPassConfig.cpp
+++ llvm/lib/CodeGen/TargetPassConfig.cpp
@@ -796,10 +796,6 @@
     if (addLegalizeMachineIR())
       return true;
 
-    // Before running the register bank selector, ask the target if it
-    // wants to run some passes.
-    addPreRegBankSelect();
-
     if (addRegBankSelect())
       return true;
 
Index: llvm/include/llvm/CodeGen/TargetPassConfig.h
===================================================================
--- llvm/include/llvm/CodeGen/TargetPassConfig.h
+++ llvm/include/llvm/CodeGen/TargetPassConfig.h
@@ -251,10 +251,6 @@
   /// sequence into one that can be selected by the target.
   virtual bool addLegalizeMachineIR() { return true; }
 
-  /// This method may be implemented by targets that want to run passes
-  /// immediately before the register bank selection.
-  virtual void addPreRegBankSelect() {}
-
   /// This method should install a register bank selector pass, which
   /// assigns register banks to virtual registers without a register
   /// class or register banks.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71176.232738.patch
Type: text/x-patch
Size: 1162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191208/db803eda/attachment.bin>