[llvm] 1c4dd3a - [InstSimplify] fold copysign with negated operand, part 2

[Sanjay Patel via llvm-commits]

Author: Sanjay Patel
Date: 2019-12-08T10:16:29-05:00
New Revision: 1c4dd3ae2f34541e53ad0110f261421083bc0157

URL: https://github.com/llvm/llvm-project/commit/1c4dd3ae2f34541e53ad0110f261421083bc0157
DIFF: https://github.com/llvm/llvm-project/commit/1c4dd3ae2f34541e53ad0110f261421083bc0157.diff

LOG: [InstSimplify] fold copysign with negated operand, part 2

This is another transform suggested in PR44153:
https://bugs.llvm.org/show_bug.cgi?id=44153

Unlike rG12f39e0fede9, it doesn't look like the
backend matches this variant.

Added: 
    

Modified: 
    llvm/lib/Analysis/InstructionSimplify.cpp
    llvm/test/Transforms/InstSimplify/call.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/InstructionSimplify.cpp b/llvm/lib/Analysis/InstructionSimplify.cpp
index d151b78f04c0..22a76a05595d 100644
--- a/llvm/lib/Analysis/InstructionSimplify.cpp
+++ b/llvm/lib/Analysis/InstructionSimplify.cpp
@@ -5091,7 +5091,9 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1,
     if (Op0 == Op1)
       return Op0;
     // copysign -X, X --> X
-    if (match(Op0, m_FNeg(m_Specific(Op1))))
+    // copysign X, -X --> -X
+    if (match(Op0, m_FNeg(m_Specific(Op1))) ||
+        match(Op1, m_FNeg(m_Specific(Op0))))
       return Op1;
     break;
   case Intrinsic::maxnum:

diff  --git a/llvm/test/Transforms/InstSimplify/call.ll b/llvm/test/Transforms/InstSimplify/call.ll
index a8a9bf54378e..15c56d233e8d 100644
--- a/llvm/test/Transforms/InstSimplify/call.ll
+++ b/llvm/test/Transforms/InstSimplify/call.ll
@@ -943,8 +943,7 @@ define <2 x double> @copysign_same_operand_vec(<2 x double> %x) {
 define float @negated_sign_arg(float %x) {
 ; CHECK-LABEL: @negated_sign_arg(
 ; CHECK-NEXT:    [[NEGX:%.*]] = fsub ninf float -0.000000e+00, [[X:%.*]]
-; CHECK-NEXT:    [[R:%.*]] = call arcp float @llvm.copysign.f32(float [[X]], float [[NEGX]])
-; CHECK-NEXT:    ret float [[R]]
+; CHECK-NEXT:    ret float [[NEGX]]
 ;
   %negx = fsub ninf float -0.0, %x
   %r = call arcp float @llvm.copysign.f32(float %x, float %negx)
@@ -954,8 +953,7 @@ define float @negated_sign_arg(float %x) {
 define <2 x double> @negated_sign_arg_vec(<2 x double> %x) {
 ; CHECK-LABEL: @negated_sign_arg_vec(
 ; CHECK-NEXT:    [[NEGX:%.*]] = fneg afn <2 x double> [[X:%.*]]
-; CHECK-NEXT:    [[R:%.*]] = call arcp <2 x double> @llvm.copysign.v2f64(<2 x double> [[X]], <2 x double> [[NEGX]])
-; CHECK-NEXT:    ret <2 x double> [[R]]
+; CHECK-NEXT:    ret <2 x double> [[NEGX]]
 ;
   %negx = fneg afn <2 x double> %x
   %r = call arcp <2 x double> @llvm.copysign.v2f64(<2 x double> %x, <2 x double> %negx)