[PATCH] D70966: [ARM] Teach the Arm cost model that a Shift can be folded into other instructions

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 02:35:22 PST 2019


samparker added a comment.
Herald added a subscriber: wuzish.

The Arm logic looks fine by me, but the tests look somewhat lacking! I'm not asking for testing all combinations, but do we have an example that we could use..?



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:903
   /// values so the TTI can analyze those values searching for special
   /// cases or optimizations based on those values.
   int getArithmeticInstrCost(
----------------
Should probably document the new optional argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70966/new/

https://reviews.llvm.org/D70966





More information about the llvm-commits mailing list