[PATCH] D70800: Fix AArch64 AAPCS frame record chain

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 08:31:57 PST 2019


sdesmalen added a comment.

Thanks for creating a fix for this @logan!



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2289
+      AArch64FunctionInfo *AFI = MF.getInfo<AArch64FunctionInfo>();
+      if (Reg1 == AArch64::FP)
+        AFI->setFrameRecordOffset((RPI.Offset + 1) * Size);
----------------
There is a condition here that is not yet tested. If the frame-record is saved that is both LR and FP, not just FP, so is this case needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70800/new/

https://reviews.llvm.org/D70800





More information about the llvm-commits mailing list