[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:266
 
+static cl::TokenizerCallback getRspQuoting(SmallVector<const char *, 0> &Argv) {
+  cl::TokenizerCallback Default =
----------------
`MatchFlagWithArg` function defined in ar_main does something very similar to this function, so can you factor it out and then use that function instead of writing a new one?

That doesn't only reduce the code size but also allows users use `--rsp-quoting <style>` in addition to `--rsp-quoting=<style>`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665