[PATCH] D70009: [ARM][ReachingDefAnalysis] Use RDA for loloops

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 13 03:47:51 PST 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:138
   MF = &mf;
+  MF->getProperties().set(MachineFunctionProperties::Property::TracksLiveness);
   TRI = MF->getSubtarget().getRegisterInfo();
----------------
dmgreen wrote:
> Can you explain this? Is it valid to just set this property?
This pass doesn't change the code so this should be fine. But now I'm thinking that this pass also should require that liveness information is correct on entry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70009/new/

https://reviews.llvm.org/D70009





More information about the llvm-commits mailing list