[PATCH] D67437: [SystemZ] Swap compare operands in foldMemoryOperandImpl() if possible.

Thu Nov 7 01:45:40 PST 2019

jonpa added inline comments.

================
Comment at: llvm/lib/Target/SystemZ/SystemZInstrInfo.cpp:1769
+
+int32_t SystemZInstrInfo::getSwappedCCMask(int32_t InCCMask) const {
+  switch(InCCMask) {
----------------
uweigand wrote:
> This does not at all depend on a SystemZInstrInfo object, so it should not require callers to pass one in.  Could be either made a static member function, or maybe just a non-class function (probably in the SystemZ namespace).
Ah, right...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67437/new/

https://reviews.llvm.org/D67437