[PATCH] D67437: [SystemZ] Swap compare operands in foldMemoryOperandImpl() if possible.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 11:32:33 PST 2019


uweigand added a comment.

See minor comment inline.  Otherwise, this now looks good to me, but we should check performance results before checking it in ...



================
Comment at: llvm/lib/Target/SystemZ/SystemZInstrInfo.cpp:1769
+
+int32_t SystemZInstrInfo::getSwappedCCMask(int32_t InCCMask) const {
+  switch(InCCMask) {
----------------
This does not at all depend on a SystemZInstrInfo object, so it should not require callers to pass one in.  Could be either made a static member function, or maybe just a non-class function (probably in the SystemZ namespace).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67437/new/

https://reviews.llvm.org/D67437





More information about the llvm-commits mailing list