[PATCH] D69326: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (3)

[Joan LLuch via Phabricator via llvm-commits]

joanlluch added a comment.

@spatel  Thanks for reviewing and commiting my previous patches on this subject. I have now been given commit access. I have not tried yet, but it should be good.

I still need this to be reviewed, however in this case I am unsure about how to present test cases because there's no trunk target that directly benefits from this particular patch. I updated the description summary to explain this. I think that this should be commited to trunk because it fixes an actual case of the general LLVM issue that affects targets meeting the conditions. I can present the example of an out-of-trunk target but I understand that this is not particularly helpful. I can also copy/paste parts or the SelectionDAG debug output to at least show what's the difference before and after applying the patch.

Any suggestions on what to do?

Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69326/new/

https://reviews.llvm.org/D69326