[PATCH] D69815: [AMDGPU] deduplicate tablegen predicates

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 12:13:08 PST 2019


rampitec marked an inline comment as done.
rampitec added a comment.

In D69815#1732912 <https://reviews.llvm.org/D69815#1732912>, @arsenm wrote:

> Where are the redundant settings coming from?


For example in MIMG:

  let SubtargetPredicate = isGFX6GFX7GFX8GFX9;
  let AssemblerPredicate = isGFX6GFX7GFX8GFX9;

This is the obvious place, but it is in fact hard to track when we start coping predicates from pseudos to real instructions and then concat all of that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69815/new/

https://reviews.llvm.org/D69815





More information about the llvm-commits mailing list