[PATCH] D69815: [AMDGPU] deduplicate tablegen predicates

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 12:04:12 PST 2019


arsenm added a comment.

Where are the redundant settings coming from?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructions.td:81-84
+  list<Predicate> ret =
+    !foldl([pred], lst, acc, cur,
+           !listconcat(acc, !if(!eq(!cast<string>(cur),!cast<string>(pred)),
+                                [], [cur])));
----------------
Should add comment that this deduplicates


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69815/new/

https://reviews.llvm.org/D69815





More information about the llvm-commits mailing list