[PATCH] D69369: [NFC] Add a unit test exposing lack of SCEV invalidation in LICM during code hoisting

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

I think this is a great example of a unit test actually.
Getting to the scenario of forcing ScEv to cache the `Load`, so we can verify it is no longer properly cached after the Load is hoisted is harder to do in a lit test such that it's so easy to understand, like it is in this unit test.

I think @reames makes great point that we should have a more extensive validation for ScEv and be able to use that in lit tests. If you can take that on, I would be happy to look at the patch.
I don't think we should block the fix that depends on this patch on it though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69369/new/

https://reviews.llvm.org/D69369