[PATCH] D69369: [NFC] Add a unit test exposing lack of SCEV invalidation in LICM during code hoisting

[Daniil Suchkov via Phabricator via llvm-commits]

DaniilSuchkov added a comment.

In D69369#1723838 <https://reviews.llvm.org/D69369#1723838>, @reames wrote:

> I think you can write this test better as an lit test with strict validation.  I assume SCEV has an expensive asserts mode - if not, we should add one - and thus this can be written as a lit test with an extra flag to opt.


There is such a mode in SCEV, but it is explicitly limited to backedge taken count verification (and even there some questionable cases are explicitly ignored). I'm not sure it will be easy to convince folks to extend it.
And you suggest to use extra SCEV validation to force SCEV to cache query results before LICM invocation, right? (to have the effect of line 70 from this test)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69369/new/

https://reviews.llvm.org/D69369