[PATCH] D69051: Handle libhwasan system allocator fallback during thread initialisation

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 16:31:01 PDT 2019


pcc added a comment.

In D69051#1713765 <https://reviews.llvm.org/D69051#1713765>, @eugenis wrote:

> > Another approach I considered was to make GenerateRandomTag return a known
> >  non-zero tag when tagging is disabled for the current thread.
>
> I think this is not a bad idea. Could we use a fixed non-zero tag in the allocator under the same condition, i.e.
>
>   (t->TaggingIsDisabled() && !flags()->disable_allocator_tagging)
>   
>
> @pcc WDYT?


SGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69051/new/

https://reviews.llvm.org/D69051





More information about the llvm-commits mailing list