[PATCH] D69051: Handle libhwasan system allocator fallback during thread initialisation

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

> Another approach I considered was to make GenerateRandomTag return a known
>  non-zero tag when tagging is disabled for the current thread.

I think this is not a bad idea. Could we use a fixed non-zero tag in the allocator under the same condition, i.e.

  (t->TaggingIsDisabled() && !flags()->disable_allocator_tagging)

@pcc WDYT?



================
Comment at: compiler-rt/lib/hwasan/hwasan_allocator.cpp:130
+      else
+	return REAL(malloc)(orig_size);
+#endif
----------------
Wrong indentation here makes it look like REAL(malloc) is called outside of both if-s.
Please use clang-format, and also add {} braces for the outer if block.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69051/new/

https://reviews.llvm.org/D69051