[PATCH] D63382: [InstCombine] fold a shifted zext to a select

Joan LLuch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 13 12:18:04 PDT 2019


joanlluch added a comment.

@spatel  I want to express my support to selects over bit manipulation instructions in IR, as stated above, in order to move such optimisations to DAGCombine. Ideally, this should involve the removal of some of the existing InstCombineSelect transformations, particularly most of the ones in foldSelectInstWithICmp. However, as I exposed earlier in LLVM-dev, the DAGCombine code should incorporate hooks to allow targets to decide whether such bihacks are actually profitable, or it's best to keep them as selects.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63382/new/

https://reviews.llvm.org/D63382





More information about the llvm-commits mailing list