[PATCH] D63382: [InstCombine] fold a shifted zext to a select

Joan LLuch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 12 11:31:32 PDT 2019


joanlluch added a comment.

In D63382#1707153 <https://reviews.llvm.org/D63382#1707153>, @spatel wrote:

> @joanlluch - this is a case where we could transform incoming shift to select and benefit small targets as you've noted.


Indeed, this seems to replace a shift that would be executed in all cases by a shift that will execute only if the incoming value was 1. 
I also agree with your comment above about "prefer 'select' in IR over bithacks".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63382/new/

https://reviews.llvm.org/D63382





More information about the llvm-commits mailing list