[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FunctionImportUtils.cpp:247
+        if (GVS) {
+          if (GVS->modulePath() == M.getModuleIdentifier())
+            break;
----------------
evgeny777 wrote:
> Why this check is needed?
I suppose it is because in e.g. the test case the two local F values have the same GUID and we are attempting to mark only the variable in this module.

There is already a facility for doing this - see ModuleSummaryIndex::findSummaryInModule(ValueInfo VI, StringRef ModuleId)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322