[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a subscriber: tejohnson.
evgeny777 added a comment.

Sorry, I somehow missed this. My understanding is that this is an ODR violation and should trigger linker error, instead of trying to be smart.
Adding @tejohnson



================
Comment at: llvm/lib/Transforms/Utils/FunctionImportUtils.cpp:247
+        if (GVS) {
+          if (GVS->modulePath() == M.getModuleIdentifier())
+            break;
----------------
Why this check is needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322