[PATCH] D68685: [RISCV] Scheduler description for Rocket Core

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 06:47:51 PDT 2019


lenary added a comment.

A few nits



================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket32.td:1
+//==- RISCVSchedRocket.td - Rocket Scheduling Definitions -*- tablegen -*-=//
+//
----------------
This should match the filename.


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket32.td:9
+//
+// This file defines the itinerary class data for the ARM Cortex A53 processors.
+//
----------------
Hmmmm :)


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket64.td:1
+//==- RISCVSchedRocket.td - Rocket Scheduling Definitions -*- tablegen -*-=//
+//
----------------
This should match the filename.


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket64.td:9
+//
+// This file defines the itinerary class data for the ARM Cortex A53 processors.
+//
----------------
Hmmmm :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68685/new/

https://reviews.llvm.org/D68685





More information about the llvm-commits mailing list