[PATCH] D68600: AMDGPU/GlobalISel: Fix crash on wide constant load with VGPR pointer

Wed Oct 9 14:54:08 PDT 2019

arsenm marked an inline comment as done.
arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:326-327

+// FIXME: Returns uniform if there's no source value information. This is
+// probably wrong.
 static bool isInstrUniformNonExtLoadAlign4(const MachineInstr &MI) {
----------------
nhaehnle wrote:
> You mean because `isUniformMMO` returns true if the MMO doesn't have a pointer? There's a comment in that function which justifies that (though I'm not sure whether that comment is correct).
The comment there isn't entirely wrong, but also isn't entirely correct. There can also be null without a PSV. I don't think this would ever happen in a real program, and is more a MIR semantics question.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68600/new/

https://reviews.llvm.org/D68600