[PATCH] D68600: AMDGPU/GlobalISel: Fix crash on wide constant load with VGPR pointer

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

I do have one question. Apart from that it LGTM.



================
Comment at: lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:326-327
 
+// FIXME: Returns uniform if there's no source value information. This is
+// probably wrong.
 static bool isInstrUniformNonExtLoadAlign4(const MachineInstr &MI) {
----------------
You mean because `isUniformMMO` returns true if the MMO doesn't have a pointer? There's a comment in that function which justifies that (though I'm not sure whether that comment is correct).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68600/new/

https://reviews.llvm.org/D68600