[PATCH] D67556: [ARM][AArch64][DebugInfo] Improve call site instruction interpretation

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: include/llvm/CodeGen/TargetInstrInfo.h:888
+  /// If the specific machine instruction is an instruction that adds an
+  /// immediate value to its first operand and stores it in the first, return
+  /// true along with @Source machine operand to which @Offset has been
----------------
dstenb wrote:
> I wonder if the hook should allow the source and destination to be different, as we then for example could describe cases like this:
> 
> ```
> $reg0 = add $frame-ptr, -13
> ```
> 
> If so, would it then make sense to move the LEA part of X86's `describeLoadedValue()` hook into this hook instead?
If so, should we perhaps also consider generalizing the hook so that it has a Destination out-parameter, e.g. same as `isCopyInstr()`? That could probably be helpful if we make the `describeLoadedValue()` hook aware of which register it should describe, as we discussed in D67225.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67556/new/

https://reviews.llvm.org/D67556