[PATCH] D52239: [OCaml] Add OCaml APIs to access DebugLoc info

[Josh Berdine via Phabricator via llvm-commits]

jberdine added a comment.

@whitequark I could use some feedback on the direction of this patch relative to https://reviews.llvm.org/D60902. This one implements the accessors for the debug locations directly using the newer DI C bindings. On the other hand D60902 <https://reviews.llvm.org/D60902> begins adding a hierarchy of types to the OCaml bindings, analogous to the DI hierarchy. This patch gives a more direct implementation for the debug location functions, but the other is more extensible if other DI accessors are needed later. Are either of these approaches acceptable? If not, can you explain briefly why so that I can propose an alternative?

Cc @codafi for feedback on the API choices, as experience with the C ones could carry over.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52239/new/

https://reviews.llvm.org/D52239