[PATCH] D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 17:18:03 PDT 2019


vsk added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:554
+
 void CodeExtractor::findInputsOutputs(ValueSet &Inputs, ValueSet &Outputs,
                                       const ValueSet &SinkCands) const {
----------------
Why not set a bit inside of the CodeExtractor instance the first time `findInputsOutputs` runs? Then there's no need to duplicate the 'findInputs' logic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68192/new/

https://reviews.llvm.org/D68192





More information about the llvm-commits mailing list