[PATCH] D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya updated this revision to Diff 222495.
hiraditya added a comment.

Addressed comments from @vsk

- Move input parameter validation to isEligible().

This now requires recomputing inputs in extractCodeRegion because PHI nodes, and return blocks are split. The computation cost of input is same as before because previously the input parameter would be computed on the client side (caller of extractCodeRegion) and introduce extra overhead to be taken care of.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68192/new/

https://reviews.llvm.org/D68192

Files:
  llvm/include/llvm/Transforms/Utils/CodeExtractor.h
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/test/Transforms/HotColdSplit/token-arg.ll
  llvm/unittests/Transforms/Utils/CodeExtractorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68192.222495.patch
Type: text/x-patch
Size: 6662 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190930/b3682307/attachment.bin>