[PATCH] D67721: [InstSimplify] fold fma/fmuladd with a NaN operand

Mon Sep 30 14:58:51 PDT 2019

fhahn added a comment.

In D67721#1688794 <https://reviews.llvm.org/D67721#1688794>, @spatel wrote:

> In D67721#1688783 <https://reviews.llvm.org/D67721#1688783>, @fhahn wrote:
>
> > Great. The naming of simplifyFPOp is a bit unfortunate IMO, but it handles exactly the undef & nan operand cases . LGTM.
>
>
> I'm to blame for the name. I just recently changed it from simplifyFPBinOp(). :)
>  Definitely open to suggestions for a better name - prefer more exact?
>  simplifyFPWithUndefOrNaNOperand()

Personally I think a more verbose name like the one suggested makes it a bit clearer (and the reader does not necessarily have to check the function implementation). But this is mostly a personal preference I think.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67721/new/

https://reviews.llvm.org/D67721