[PATCH] D67721: [InstSimplify] fold fma/fmuladd with a NaN operand

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 14:54:38 PDT 2019


spatel added a comment.

In D67721#1688783 <https://reviews.llvm.org/D67721#1688783>, @fhahn wrote:

> Great. The naming of simplifyFPOp is a bit unfortunate IMO, but it handles exactly the undef & nan operand cases . LGTM.


I'm to blame for the name. I just recently changed it from simplifyFPBinOp(). :)
Definitely open to suggestions for a better name - prefer more exact?
simplifyFPWithUndefOrNaNOperand()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67721/new/

https://reviews.llvm.org/D67721





More information about the llvm-commits mailing list