[PATCH] D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic

Mon Sep 30 08:56:32 PDT 2019

hiraditya marked 2 inline comments as done.
hiraditya added inline comments.

================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:344
+
+  if (!CE.validInputs(Inputs))
+    return nullptr;
----------------
compnerd wrote:
> For some reason it feels like an odd name to me.  What do you think of something like `validateDataDependencies` or something along those lines?  I think the fact that input is slightly fuzzy is why it just feels odd, but, I can understand where that comes from too.
Sounds good.

================
Comment at: llvm/test/Transforms/HotColdSplit/token-arg.ll:1
+; RUN: opt -S %s -hotcoldsplit -o /dev/null
+define void @zot() personality i8* bitcast (i32 (...)* @bar to i8*) {
----------------
compnerd wrote:
> Might not be a bad idea to ensure that the transformation is idempotent - that is to have checks on the output IR
sure

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68192/new/

https://reviews.llvm.org/D68192