[PATCH] D68063: Propeller: LLVM support for basic block sections

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/AsmPrinterHandler.h:71
+
+  // Process beginning and end of a basic block, with basic block sections.
+  virtual void beginBasicBlock(const MachineBasicBlock &MBB) { }
----------------
Please doxygenify all comments in this patch according to https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments.


================
Comment at: llvm/test/DebugInfo/X86/basicblock-sections-cfi.ll:85
+
+attributes #0 = { noinline nounwind optnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable willreturn }
----------------
Please try to remove all string attributes that aren't strictly necessary, they are a maintenance burden.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063