[PATCH] D68063: Propeller: LLVM support for basic block sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:81
+      };
+      CachedMCSymbol = Ctx.getOrCreateSymbol(Unary(getNumber()) +
+                           Twine(Delimiter) + "BB" + Twine(Delimiter) +
----------------
`std::string(getNumber(), 'a')`


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:1374
+
+  case MCSymbolRefExpr::VK_SIZE:
+    if (MAI->shouldRelocateWithSymbols())
----------------
R_*_SIZE is x86 specific. If you want to use it on other architectures, it will require an ABI change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063