[PATCH] D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245)

Thu Sep 26 16:39:33 PDT 2019

wolfgangp added a comment.

In D67998#1683795 <https://reviews.llvm.org/D67998#1683795>, @jhenderson wrote:

> In D67998#1682945 <https://reviews.llvm.org/D67998#1682945>, @wolfgangp wrote:
>
> > Yes, good observation. There is also the question what to do if the sizes of 2 different entries with the same address don't match. This should probably elicit a warning.
>
>
> <snip>
>
> 1. Display the first entry size, for each symbol. This is probably the simplest.

For some reason, I didn't see your response until I had posted my updated. I basically implemented number 3.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67998/new/

https://reviews.llvm.org/D67998