[PATCH] D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245)

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 222015.
wolfgangp marked 4 inline comments as done.
wolfgangp edited the summary of this revision.
wolfgangp added a comment.

1. Rebased with the latest upstream changes.
2. Addressed review comments as follows:
  - Keeping track of stack sizes already dumped so that duplicate entries only are printed once.
  - Issue a warning when a duplicate entry with a different stack size is encountered.
  - Simplified code by collapsing some warning code into a lambda.
  - added the appropriate test cases for the changed functionality and added one for STT_NOTYPE.
  - added an early return in a case where no valid symbol is found.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67998/new/

https://reviews.llvm.org/D67998

Files:
  test/tools/llvm-readobj/stack-sizes.test
  tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67998.222015.patch
Type: text/x-patch
Size: 12368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190926/d2df6398/attachment.bin>