[PATCH] D67529: [TextAPI] Introduce TBDv4

Tue Sep 24 10:31:07 PDT 2019

ributzka added inline comments.

================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:372
+                                      "install-name: Test.dylib\n"
+                                      "swift-abi-version: 1.0\n"
+                                      "...\n";
----------------
cishida wrote:
> ributzka wrote:
> > For TBD v4 the swift-abi-version should be just an integer. In this case it should be just 1.
> for tbdv-4 should it be considered malformed to pass a float? as opposed to currently rounding
I wouldn't call it a float. It used to be the Swift version string in previous TBD versions and now it is the Swift ABI version, which is only an integer. Passing anything else for TBD v4 should be considered malformed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67529/new/

https://reviews.llvm.org/D67529