[PATCH] D67529: [TextAPI] Introduce TBDv4

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 12:36:00 PDT 2019


cishida added inline comments.


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:372
+                                      "install-name: Test.dylib\n"
+                                      "swift-abi-version: 1.0\n"
+                                      "...\n";
----------------
ributzka wrote:
> For TBD v4 the swift-abi-version should be just an integer. In this case it should be just 1.
for tbdv-4 should it be considered malformed to pass a float? as opposed to currently rounding


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67529/new/

https://reviews.llvm.org/D67529





More information about the llvm-commits mailing list