[PATCH] D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options

Mon Sep 23 11:32:08 PDT 2019

asmith marked an inline comment as done.
asmith added a comment.

In D67689#1679198 <https://reviews.llvm.org/D67689#1679198>, @jhenderson wrote:

> Thinks for the patch! I haven't had time to review the meat of it yet, but will try to get back to it in the next couple of days. One quick question in the meantime: what's the motivation behind this? Is it to improve GNU compatibility?

I need these options to use llvm-objcopy when building uboot.

================
Comment at: llvm/include/llvm/Object/ELF.h:408
                        " has a sh_offset (0x" + Twine::utohexstr(Offset) +
-                       ") + sh_size (0x" + Twine(Size) +
+                       ") + sh_size (0x" + Twine::utohexstr(Size) +
                        ") that cannot be represented");
----------------
jhenderson wrote:
> This and a couple of tests look like an unrelated change?
This is a bug fix. The value wasn’t printed correctly.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67689/new/

https://reviews.llvm.org/D67689