[PATCH] D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options

[Hui Huang via Phabricator via llvm-commits]

Hui added inline comments.


================
Comment at: llvm/include/llvm/Object/ELF.h:408
                        " has a sh_offset (0x" + Twine::utohexstr(Offset) +
-                       ") + sh_size (0x" + Twine(Size) +
+                       ") + sh_size (0x" + Twine::utohexstr(Size) +
                        ") that cannot be represented");
----------------
jhenderson wrote:
> This and a couple of tests look like an unrelated change?
This diagnostic message probably emitted when the layout of resized sections was not correctly done. However it is misleading.  The 'Size' is supposed to be in hex while it is not.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67689/new/

https://reviews.llvm.org/D67689