[PATCH] D66969: Output XCOFF object text section

[Xing Xue via Phabricator via llvm-commits]

xingxue added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:293
+  // Write the program code control sections one at a time.
+  for (const auto CSection : ProgramCodeCsects)
+    Asm.writeSectionData(W.OS, CSection.MCCsect, Layout);
----------------
DiggerLin wrote:
> hubert.reinterpretcast wrote:
> > hubert.reinterpretcast wrote:
> > > Please don't copy the `ControlSection`s.
> > We already use `Sec` and `Csect` for similar cases. I don't think we need to add `CSection` into the mix.
> change as suggestion
I'd suggest to use `Csect` to be consistent with what is used in this file for other similar cases.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66969/new/

https://reviews.llvm.org/D66969