[PATCH] D67483: [ARM] Reserve an emergency spill slot for fp16 addressing modes that need it

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 18:02:07 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

We never call estimateRSStackSizeLimit on Thumb1; we just use a static estimate based on the range of tSTRspi, since in practice almost all functions will contain one.



================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1526
           break;
         }
+        // t2ADDri will be transformed into a t2ADDri12 if it does not fit.
----------------
Not that it's important, but it shouldn't really matter if ADDri etc. is out of range: we can use the destination as a scratch register.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67483/new/

https://reviews.llvm.org/D67483





More information about the llvm-commits mailing list