[PATCH] D67696: [tools] Mark output of tools as text if it is really text

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 10:49:17 PDT 2019


rnk added a comment.

The main effect that I'm aware of here is that this will do CRLF conversion on Windows. Are we sure we really want that? I just did the opposite to TableGen output in rL371683 <https://reviews.llvm.org/rL371683>. In general, I think the majority of tools that write text use OF_Text, so your change makes this minority of tools consistent with the other ones.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67696/new/

https://reviews.llvm.org/D67696





More information about the llvm-commits mailing list