[PATCH] D67696: [tools] Mark output of tools as text if it is really text

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: llvm/lib/IR/RemarkStreamer.cpp:129
   auto RemarksFile =
-      std::make_unique<ToolOutputFile>(RemarksFilename, EC, sys::fs::OF_None);
+      std::make_unique<ToolOutputFile>(RemarksFilename, EC, sys::fs::OF_Text);
   // We don't use llvm::FileError here because some diagnostics want the file
----------------
Depending on `RemarksFormat`, the output can also be LLVM Bitstream. Should this set `OF_Text` only if the format is YAML?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67696/new/

https://reviews.llvm.org/D67696