[PATCH] D67666: GSYM: Add the llvm::gsym::Header header class with tests

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/Header.h:90
+  /// \returns True if the header is valid and if the version is supported.
+  bool isValid() const {
+    if (Magic != GSYM_MAGIC)
----------------
JDevlieghere wrote:
> Any reason you prefer `isValid` over `operator bool`?
As usual, I'm going to point out that it may be nicer to have the parser return an Expected<Header> instead of a header that may be invalid.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67666/new/

https://reviews.llvm.org/D67666