[PATCH] D67666: GSYM: Add the llvm::gsym::Header header class with tests

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: include/llvm/DebugInfo/GSYM/Header.h:90
+  /// \returns True if the header is valid and if the version is supported.
+  bool isValid() const {
+    if (Magic != GSYM_MAGIC)
----------------
Any reason you prefer `isValid` over `operator bool`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67666/new/

https://reviews.llvm.org/D67666