[PATCH] D66724: [AIX]Emit function descriptor csect in assembly

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 17:22:41 PDT 2019


hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/test_func_desc.ll:60
+; CHECK: .lglobl .static_foo
+; CHECK: .csect static_foo[DS]
+; CHECK-NEXT: static_foo:
----------------
Xiangling_L wrote:
> hubert.reinterpretcast wrote:
> > This is technically not needed for this case, and XL does not generate this unnecessary function descriptor.
> Yes, this function descriptor is unnecessary. But I vaguely recall that we decided the optimization of function descriptor generation would not be taken into consideration temporarily. So I am thinking is that okay to leave it as it is, and remove this part when we have optimization implemented?
Sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66724/new/

https://reviews.llvm.org/D66724





More information about the llvm-commits mailing list