[PATCH] D66724: [AIX]Emit function descriptor csect in assembly

Mon Sep 16 08:53:41 PDT 2019

Xiangling_L marked 22 inline comments as done.
Xiangling_L added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/test_func_desc.ll:60
+; CHECK: .lglobl .static_foo
+; CHECK: .csect static_foo[DS]
+; CHECK-NEXT: static_foo:
----------------
hubert.reinterpretcast wrote:
> This is technically not needed for this case, and XL does not generate this unnecessary function descriptor.
Yes, this function descriptor is unnecessary. But I vaguely recall that we decided the optimization of function descriptor generation would not be taken into consideration temporarily. So I am thinking is that okay to leave it as it is, and remove this part when we have optimization implemented?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66724/new/

https://reviews.llvm.org/D66724