[PATCH] D66602: Add a LineTable class to GSYM and test it.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 13:50:01 PDT 2019


clayborg closed this revision.
clayborg added a comment.

$ svn commit
Sending        include/llvm/DebugInfo/GSYM/FunctionInfo.h
Adding         include/llvm/DebugInfo/GSYM/LineTable.h
Sending        lib/DebugInfo/GSYM/CMakeLists.txt
Sending        lib/DebugInfo/GSYM/FunctionInfo.cpp
Adding         lib/DebugInfo/GSYM/LineTable.cpp
Sending        unittests/DebugInfo/GSYM/GSYMTest.cpp
Transmitting file data ......done
Committing transaction...
Committed revision 371657.



================
Comment at: include/llvm/DebugInfo/GSYM/FunctionInfo.h:46
     /// and we need to be able to tell which one is the better object to use.
-    return !Lines.empty() || Inline.isValid();
+    return !LineTable.empty() || Inline.isValid();
   }
----------------
Sounds good. I will make the changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66602/new/

https://reviews.llvm.org/D66602





More information about the llvm-commits mailing list